Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection remove command #1444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-jsikorski
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

As per user request, this PR adds command snow connection remove to remove connection from config file by providing it's name

@sfc-gh-jsikorski sfc-gh-jsikorski requested review from a team as code owners August 14, 2024 08:03
@sfc-gh-turbaszek
Copy link
Contributor

How do you now where the connection should be removed? How do you determine if it's from config.toml or connections.toml?

@sfc-gh-jsikorski
Copy link
Contributor Author

Good point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants