Load private key from env variable #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
force-pushed
the
load-private-key-from-env
branch
4 times, most recently
from
7023113
to
d7613ff
Compare
sfc-gh-astus
commented
Sep 11, 2024
CONTRIBUTING.md
Outdated
Comment on lines
85
to
87
| - `SNOWFLAKE_CONNECTIONS_INTEGRATION_PRIVATE_KEY_FILE` (Preferable) | ||
| - `SNOWFLAKE_CONNECTIONS_INTEGRATION_PRIVATE_KEY_PATH` (Alternative) | ||
| - `SNOWFLAKE_CONNECTIONS_INTEGRATION_PRIVATE_KEY_RAW` (Loads the private key directly from the environment variable) |
There was a problem hiding this comment.
Should be only RAW
sfc-gh-astus
commented
Sep 11, 2024
RELEASE-NOTES.md
Outdated
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| ## New additions | |||
| * Added templates expansion of arbitrary files for Native Apps through `templates` processor. | |||
| * Added `SNOWFLAKE_..._PRIVATE_KEY_RAW` environment variable to pass private key as a raw string. | |||
There was a problem hiding this comment.
Should I add this? This is only int tests thing.
sfc-gh-astus
force-pushed
the
load-private-key-from-env
branch
from
d7613ff
to
17bee13
Compare
sfc-gh-astus
force-pushed
the
load-private-key-from-env
branch
from
17bee13
to
7ea05c6
Compare
sfc-gh-turbaszek
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Added new env variable to load private key directly from env.