Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1643309 Add snow ws version list command #1574

Merged
merged 5 commits into from
Sep 17, 2024
Merged

SNOW-1643309 Add snow ws version list command #1574

merged 5 commits into from
Sep 17, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

@sfc-gh-fcampbell sfc-gh-fcampbell commented Sep 13, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Adds snow ws version list command to be invoked on an app package entity. Behaves the same as snow app version list.

Base automatically changed from frank-refactor-app-deploy to main September 13, 2024 19:39
@sfc-gh-fcampbell sfc-gh-fcampbell force-pushed the frank-version-list-action branch 3 times, most recently from 7accdba to 3e4e3b4 Compare September 16, 2024 19:08
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review September 16, 2024 19:28
sfc-gh-melnacouzi
sfc-gh-melnacouzi reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-melnacouzi sfc-gh-melnacouzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please revisit this?
I don't think we should use snow ws version-list. We should use snow ws version list instead.

@sfc-gh-fcampbell
Copy link
Contributor Author

Yeah I'm fine with it, that's what the auto-generation is gonna do anyways

sfc-gh-cgorrie
sfc-gh-cgorrie previously approved these changes Sep 16, 2024
View reviewed changes
@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Add snow ws version-list command Add snow ws version list command Sep 16, 2024
sfc-gh-gbloom
sfc-gh-gbloom reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-gbloom sfc-gh-gbloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add integration test coverage as well?

src/snowflake/cli/api/entities/application_package_entity.py Outdated
Get all existing versions, if defined, for an application package.
It executes a 'show versions in application package' query and returns all the results.
"""
executor = get_sql_executor()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, for consistency with the rest of the code

Suggested change
executor = get_sql_executor()
sql_executor = get_sql_executor()

src/snowflake/cli/_plugins/workspace/commands.py Show resolved Hide resolved
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit cc61401 into main Sep 17, 2024
21 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-version-list-action branch September 17, 2024 15:05
@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Add snow ws version list command SNOW-1643309 Add snow ws version list command Sep 17, 2024
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-fcampbell
Add snow ws version list command (#1574)
800f8fd 
Adds `snow ws version list` command to be invoked on an app package entity. Behaves the same as `snow app version list`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-gbloom sfc-gh-gbloom sfc-gh-gbloom left review comments

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

@sfc-gh-cgorrie sfc-gh-cgorrie sfc-gh-cgorrie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-fcampbell @sfc-gh-cgorrie @sfc-gh-melnacouzi @sfc-gh-gbloom