Slash in git execute fix #1575
Merged
Slash in git execute fix #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
force-pushed
the
slash-in-git-execute-fix
branch
3 times, most recently
from
f281ad4
to
068c600
Compare
sfc-gh-astus
force-pushed
the
slash-in-git-execute-fix
branch
from
068c600
to
ec22970
Compare
sfc-gh-astus
commented
Sep 17, 2024
|
Add to release notes |
sfc-gh-astus
force-pushed
the
slash-in-git-execute-fix
branch
from
ec22970
to
ba5e83f
Compare
| @@ -27,16 +27,21 @@ | |||
| from snowflake.cli.api.identifiers import FQN | |||
| from snowflake.connector.cursor import SnowflakeCursor | |||
|
|
|||
| OMIT_FIRST = slice(1, None) | |||
There was a problem hiding this comment.
Can you add comment explaining what is the reasoning behind those slices?
There was a problem hiding this comment.
Reason was to replace magic numbers [3:], [1:].
| # Check if path contains quotes and split it accordingly | ||
| if '/"' in path and '"/' in path: | ||
| if path.count('"') > 2: | ||
| raise ValueError('Too much " in path, expected 2.') |
There was a problem hiding this comment.
Let's make this more meaningful. Something like "invalid string blah blah..". Also please raise BadUsage error to handle this with better UX
Comment on lines
130
to
135
| if path_parts[2] and path_parts[2] != "/": | ||
| after_quoted_part = GitManager._split_path_without_empty_parts( | ||
| path_parts[2] | ||
| ) | ||
| else: | ||
| after_quoted_part = [] |
There was a problem hiding this comment.
Suggested change
| if path_parts[2] and path_parts[2] != "/": | |
| after_quoted_part = GitManager._split_path_without_empty_parts( | |
| path_parts[2] | |
| ) | |
| else: | |
| after_quoted_part = [] | |
| if path_parts[2] == "/": | |
| after_quoted_part = [] | |
| else: | |
| after_quoted_part = GitManager._split_path_without_empty_parts( | |
| path_parts[2] | |
| ) |
WDYT?
There was a problem hiding this comment.
Looks much better 👍
sfc-gh-astus
force-pushed
the
slash-in-git-execute-fix
branch
from
ba5e83f
to
3671164
Compare
sfc-gh-turbaszek
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Fixed
git executefor branches with/in name.Fixed
executecommand for files with space in name.