Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Comment Support for Streamlit App Creation #1580

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Add Comment Support for Streamlit App Creation #1580

merged 7 commits into from
Sep 19, 2024

Conversation

sfc-gh-vmaleki
Copy link
Collaborator

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Added support for the comment field in the Streamlit app deployment command.
  • Updated unit tests to include validation of the comment field functionality.
  • Manually tested the changes on MacOS to verify the deployment of the Streamlit app with the added comment field.

@sfc-gh-vmaleki sfc-gh-vmaleki marked this pull request as ready for review September 16, 2024 23:32
@sfc-gh-vmaleki sfc-gh-vmaleki requested review from a team as code owners September 16, 2024 23:32
sfc-gh-astus
sfc-gh-astus previously approved these changes Sep 18, 2024
View reviewed changes
@sfc-gh-vmaleki sfc-gh-vmaleki enabled auto-merge (squash) September 18, 2024 16:53
@sfc-gh-vmaleki sfc-gh-vmaleki merged commit 0a9cde5 into main Sep 19, 2024
21 checks passed
@sfc-gh-vmaleki sfc-gh-vmaleki deleted the vmaleki-add-comment-support branch September 19, 2024 07:29
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-vmaleki
Add Comment Support for Streamlit App Creation (#1580)
0d07af9 
* Add support for 'comment' field in Streamlit app deployment

* Added unit tests for 'comment' support in Streamlit app deployment

* Added test case for StreamlitEntityModel to include comment field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-vmaleki @sfc-gh-astus