Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement metrics counter feature tracking for NADE #1597

Merged
merged 40 commits into from
Sep 26, 2024
Merged

implement metrics counter feature tracking for NADE #1597

merged 40 commits into from
Sep 26, 2024

Commits on Sep 18, 2024

  1. wip: implement metrics and implementation, tests failing

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7f2618a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    bd93cc3 View commit details
    Browse the repository at this point in the history

  3. fix missing counter field causing test fails

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4470cd6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. add pdf template instrumentation

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b6101ab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    945bc3c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5ae5bc7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    fe6926d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    61dd177 View commit details
    Browse the repository at this point in the history

  6. remove validate option callback for failing tests

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9145b67 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    9dccb93 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    949edf0 View commit details
    Browse the repository at this point in the history

  9. remove duplicate tracked counters, fix bug with carryover metrics bet… 

    …ween commands
    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e8a3956 View commit details
    Browse the repository at this point in the history

  10. add integration tests for feature tracking metrics

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1316163 View commit details
    Browse the repository at this point in the history

  11. fix improper typing for None

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    95ae58c View commit details
    Browse the repository at this point in the history

  12. implement metrics custom equality comparison for failing test

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d24aedb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    674decd View commit details
    Browse the repository at this point in the history

  2. review fixes

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c41044e View commit details
    Browse the repository at this point in the history

  3. extract metrics update from render_definition_template

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f2def23 View commit details
    Browse the repository at this point in the history

  4. fix key being used for metrics

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ef26a09 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a17a0d4 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6cc8c5f View commit details
    Browse the repository at this point in the history

  7. add -> increment; move snowpark counter check to e2e

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b444cf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. remove snowpark processor test from e2e

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    0608844 View commit details
    Browse the repository at this point in the history

  2. make sql template test name not confusing

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f57f5a7 View commit details
    Browse the repository at this point in the history

  3. fix test local changes

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    28912ab View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    618dc43 View commit details
    Browse the repository at this point in the history

  5. remove fixture to simplify test utils now that e2e is no longer needed

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2326701 View commit details
    Browse the repository at this point in the history

  6. fix post deploy scripts not being picked up properly due to extraneou… 

    …s conditional check
    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    4b26b6f View commit details
    Browse the repository at this point in the history

  7. add back post deploy check and move instrumentation to fix failing test

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b268e4e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    8d0c4a4 View commit details
    Browse the repository at this point in the history

  9. fix pre-commit errors

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    65f1d9f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge remote-tracking branch 'origin/main' into mchok-metrics-counter… 

    …-feature-tracking
    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    dde4337 View commit details
    Browse the repository at this point in the history

  2. adjust counter naming and add comment for convention

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a796c11 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    712b46a View commit details
    Browse the repository at this point in the history

  4. adjust constant names and docstring

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    23ccfac View commit details
    Browse the repository at this point in the history

  5. move processors instrumentation, centralize post deploy hook instrume… 

    …ntation, introduce set_counter_default
    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fbb155c View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5304633 View commit details
    Browse the repository at this point in the history

  2. remove wrong comment

    @sfc-gh-mchok
    sfc-gh-mchok committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dd2f34a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8af47f9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into mchok-metrics-counter-feature-tracking

    @sfc-gh-mchok
    sfc-gh-mchok authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b6a272b View commit details
    Browse the repository at this point in the history