Catch error on deploy for package with special comment #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
previously approved these changes
Sep 19, 2024
sfc-gh-fcampbell
approved these changes
Sep 20, 2024
sfc-gh-cgorrie
approved these changes
Sep 20, 2024
sfc-gh-vmaleki
pushed a commit
that referenced
this pull request
Sep 20, 2024
sfc-gh-vmaleki
added a commit
that referenced
this pull request
Sep 25, 2024
* Added execute command and tests for Streamlit app * Added note for execute command in release note * Added class to hide variables in tracebacks (#1599) * Rename ws migrate to migrate-definition (#1598) * Bring back glob support in streamlit (#1605) * Bring back glob support in streamlit * fixup! Bring back glob support in streamlit * Catch error on deploy for package with special comment (#1600) * Added integration test for execute streamlit command --------- Co-authored-by: Adam Stus <adam.stus@snowflake.com> Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> Co-authored-by: Parya Jafari <parya.jafari@snowflake.com>
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Added execute command and tests for Streamlit app * Added note for execute command in release note * Added class to hide variables in tracebacks (#1599) * Rename ws migrate to migrate-definition (#1598) * Bring back glob support in streamlit (#1605) * Bring back glob support in streamlit * fixup! Bring back glob support in streamlit * Catch error on deploy for package with special comment (#1600) * Added integration test for execute streamlit command --------- Co-authored-by: Adam Stus <adam.stus@snowflake.com> Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com> Co-authored-by: Parya Jafari <parya.jafari@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...
Adds a prompt for when running
app deployorws deploy(for a package entity) that was not created by the CLI.This behavior already exists for version commands.