Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numerical version when reading from manifest file #1602

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Fix numerical version when reading from manifest file #1602

merged 5 commits into from
Sep 19, 2024

Conversation

sfc-gh-bdufour
Copy link
Contributor

@sfc-gh-bdufour sfc-gh-bdufour commented Sep 19, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fixed a bug where versions read from a manifest file in snow app create could lead to a crash due to being parsed as numbers. Fixes SNOW-1653838.

@sfc-gh-bdufour sfc-gh-bdufour marked this pull request as ready for review September 19, 2024 20:41
@sfc-gh-bdufour sfc-gh-bdufour requested a review from a team as a code owner September 19, 2024 20:41
@sfc-gh-bdufour sfc-gh-bdufour changed the title Bdufour fix numerical version Fix numerical version when reading from manifest file Sep 19, 2024
sfc-gh-fcampbell
sfc-gh-fcampbell reviewed Sep 19, 2024
View reviewed changes
tests_integration/nativeapp/test_version.py


def normalize_identifier(identifier: str) -> str:
id_str = str(identifier)
Copy link
Collaborator

@sfc-gh-fcampbell sfc-gh-fcampbell Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the type this is already a str but I see that the test passes an int, so can we update the type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, updated.

tests_integration/nativeapp/test_version.py Show resolved Hide resolved
tests_integration/nativeapp/test_version.py Outdated Show resolved Hide resolved
tests_integration/nativeapp/test_version.py Outdated Show resolved Hide resolved
sfc-gh-fcampbell
sfc-gh-fcampbell previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-fcampbell sfc-gh-fcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are nits

@sfc-gh-bdufour sfc-gh-bdufour enabled auto-merge (squash) September 19, 2024 21:01
sfc-gh-bdufour and others added 5 commits September 19, 2024 17:18
@sfc-gh-bdufour @sfc-gh-fcampbell
Fix version extraction logic
565978b
@sfc-gh-bdufour @sfc-gh-fcampbell
Fixed patch logic
2724c5c
@sfc-gh-bdufour @sfc-gh-fcampbell
Update tests_integration/nativeapp/test_version.py
c73ff70 
Co-authored-by: Francois Campbell <francois.campbell@snowflake.com>
@sfc-gh-bdufour @sfc-gh-fcampbell
Update tests_integration/nativeapp/test_version.py
60202b6 
Co-authored-by: Francois Campbell <francois.campbell@snowflake.com>
@sfc-gh-bdufour @sfc-gh-fcampbell
Addressed PR comments
a86b2a0
@sfc-gh-bdufour sfc-gh-bdufour merged commit 394c493 into main Sep 19, 2024
19 checks passed
@sfc-gh-bdufour sfc-gh-bdufour deleted the bdufour-fix-numerical-version branch September 19, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-melnacouzi sfc-gh-melnacouzi sfc-gh-melnacouzi approved these changes

@sfc-gh-fcampbell sfc-gh-fcampbell sfc-gh-fcampbell approved these changes

Assignees
No one assigned
Labels
3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-bdufour @sfc-gh-melnacouzi @sfc-gh-fcampbell