Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Execute Streamlit command for running Streamlit apps #1603

Merged
merged 16 commits into from
Sep 25, 2024
Merged

Add Execute Streamlit command for running Streamlit apps #1603

merged 16 commits into from
Sep 25, 2024
+161 −28

Conversation

sfc-gh-vmaleki
Copy link
Collaborator

@sfc-gh-vmaleki sfc-gh-vmaleki commented Sep 19, 2024 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

  • Implemented the execute command for running Streamlit apps in headless mode
    using snow streamlit execute <app-name>.
  • After execution, you can get the app URL by using snow streamlit get-url <app-name> --open and open it in your browser.
  • Wrote unit tests for the execute command, following the pattern used for notebooks.
  • Updated the Streamlit manager to support execution.

@sfc-gh-vmaleki sfc-gh-vmaleki requested review from a team as code owners September 19, 2024 20:47
@sfc-gh-turbaszek
Copy link
Contributor

Can you please add integration test?

@sfc-gh-vmaleki sfc-gh-vmaleki enabled auto-merge (squash) September 20, 2024 16:20
@sfc-gh-vmaleki sfc-gh-vmaleki force-pushed the vmaleki-add-execute-streamlit-command branch from e69104a to 657e3fc Compare September 21, 2024 02:31
@sfc-gh-vmaleki sfc-gh-vmaleki force-pushed the vmaleki-add-execute-streamlit-command branch from 1cdc587 to eaa26f3 Compare September 21, 2024 03:05
sfc-gh-astus
sfc-gh-astus reviewed Sep 24, 2024
View reviewed changes
RELEASE-NOTES.md Outdated Show resolved Hide resolved
tests_integration/test_streamlit.py Outdated Show resolved Hide resolved
@sfc-gh-vmaleki sfc-gh-vmaleki merged commit 6c697d2 into main Sep 25, 2024
21 checks passed
@sfc-gh-vmaleki sfc-gh-vmaleki deleted the vmaleki-add-execute-streamlit-command branch September 25, 2024 18:35
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-vmaleki @sfc-gh-astus
@sfc-gh-turbaszek @sfc-gh-pjafari
Add Execute Streamlit command for running Streamlit apps (#1603)
f04226b 
* Added execute command and tests for Streamlit app

* Added note for execute command in release note

* Added class to hide variables in tracebacks (#1599)

* Rename ws migrate to migrate-definition (#1598)

* Bring back glob support in streamlit (#1605)

* Bring back glob support in streamlit

* fixup! Bring back glob support in streamlit

* Catch error on deploy for package with special comment (#1600)

* Added integration test for execute streamlit command

---------

Co-authored-by: Adam Stus <adam.stus@snowflake.com>
Co-authored-by: Tomasz Urbaszek <tomasz.urbaszek@snowflake.com>
Co-authored-by: Parya Jafari <parya.jafari@snowflake.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek left review comments

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-vmaleki @sfc-gh-turbaszek @sfc-gh-astus