SNOW-1643309 Move version drop to app package #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-fcampbell
force-pushed
the
frank-ws-version-drop
branch
from
13af273
to
38243cd
Compare
| """ | ||
| Drops a version defined in an application package. If --force is provided, then no user prompts will be executed. | ||
| """ | ||
| is_interactive = False |
There was a problem hiding this comment.
it might be confusing to have 2 similar variables. Can we do something like this instead?
if force:
interactive = False
policy = AllowAlwaysPolicy()
else:
policy = AskAlwaysPolicy() if interactive else DenyAlwaysPolicy()
There was a problem hiding this comment.
this was copied verbatim from https://github.com/snowflakedb/snowflake-cli/pull/1610/files#diff-7f950152d04e5fc16d6529457263e2b23df2e9f6a0023f6572d49bdb5a9a9d38L140-L147 but yeah i can change it. I'm planning a refactor of this force/interactive/policy stuff anyways
| version = to_identifier(version) | ||
|
|
||
| console.step( | ||
| f"About to drop version {version} in application package {package_name}." |
There was a problem hiding this comment.
did this message change? was there a backslash at the beginning?
There was a problem hiding this comment.
it was a multiline string when it didn't need to be since it's only one line
sfc-gh-melnacouzi
approved these changes
Sep 23, 2024
sfc-gh-sichen
pushed a commit
that referenced
this pull request
Oct 17, 2024
Moves implementation of `snow app version drop` to `ApplicationPackageEntity.version_drop` and wires it into `snow ws version drop` too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Moves implementation of
snow app version droptoApplicationPackageEntity.version_dropand wires it intosnow ws version droptoo.