Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename snowflake-cli-labs to snowflake-cli #694

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Rename snowflake-cli-labs to snowflake-cli #694

merged 5 commits into from
Jan 30, 2024
+270 −5

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

sfc-gh-astus
sfc-gh-astus reviewed Jan 30, 2024
View reviewed changes
README.md
@@ -15,7 +15,7 @@ For complete installation and usage instructions, refer to the
Requires Python >= 3.8

```bash
pip install snowflake-cli-labs
pip install snowflake-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-mheavin have to update it in docs too

sfc-gh-astus
sfc-gh-astus previously approved these changes Jan 30, 2024
View reviewed changes
@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) January 30, 2024 10:42
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit d02912d into main Jan 30, 2024
16 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the rename-snowcli-package branch January 30, 2024 10:43
sfc-gh-astus added a commit that referenced this pull request Jan 31, 2024
@sfc-gh-astus
Revert "Rename snowflake-cli-labs to snowflake-cli (#694)"
e3dfea6
sfc-gh-pjob pushed a commit that referenced this pull request Jan 31, 2024
@sfc-gh-astus
Revert "Rename snowflake-cli-labs to snowflake-cli (#694)" (#711)
7712583 
Reverting project name change because of name clash on PyPI.
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-turbaszek
Rename snowflake-cli-labs to snowflake-cli (#694)
716b2a4
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-astus
Revert "Rename snowflake-cli-labs to snowflake-cli (#694)" (#711)
89ed582 
Reverting project name change because of name clash on PyPI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

@sfc-gh-jsikorski sfc-gh-jsikorski Awaiting requested review from sfc-gh-jsikorski

@sfc-gh-mraba sfc-gh-mraba Awaiting requested review from sfc-gh-mraba

@sfc-gh-pczajka sfc-gh-pczajka Awaiting requested review from sfc-gh-pczajka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-turbaszek @sfc-gh-astus @sfc-gh-pjob