-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mac regression ci #2051
fix mac regression ci #2051
Conversation
I see this change is trying to run tests in a 3.10 python version. Are we doing this because of coming 3.8 deprecation? it is not clear from the link provided in the description |
@sfc-gh-aalam yeah Python 3.8 is going to be deprecated soon, also I found the linux test script is using python 3.10 so trying to align them. tox will create new venv of different Python versions to run so I don't think the system python matters too much here as long as it's not deprecated. but ideally we can adopt the latest python for testing which will last longer -- e.g. if we use python 3.10 we need to update the test script 2 year later. but if it's 3.12, we can use the same script for 4 years let me try if 3.12 is available on our mac test nodes. if it's available we can use 3.12 |
I have logged another JIRA to update our tests to use python 3.12 in other tests if possible https://snowflakecomputing.atlassian.net/browse/SNOW-1664019 |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
pandas-dev/pandas#58809
apache/arrow#41696
https://github.com/apache/arrow/pull/43137/files
we should use ideally the latest mac version
python 3.8 is going to be deprecated soon, switching to 3.10 to align with linux test script