Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github action version to fix coverage report #2053

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

sfc-gh-aling
Copy link
Collaborator

@sfc-gh-aling sfc-gh-aling commented Sep 10, 2024

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

our test cov has not been updated for a while: https://app.codecov.io/github/snowflakedb/snowflake-connector-python
because v3 upload action hits rate limit error
updating to v4 resolves the issue

  1. (Optional) PR for stored-proc connector:

@sfc-gh-aling sfc-gh-aling changed the title bump version bump github action version Sep 10, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review September 11, 2024 03:37
@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 11, 2024
@sfc-gh-aling sfc-gh-aling added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Sep 11, 2024
@sfc-gh-aling sfc-gh-aling changed the title bump github action version bump github action version to fix coverage report Sep 11, 2024
@sfc-gh-aling sfc-gh-aling merged commit f09991d into main Sep 11, 2024
95 of 96 checks passed
@sfc-gh-aling sfc-gh-aling deleted the fix-cov branch September 11, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants