-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-862760: Add additionalHeader support #1490
SNOW-862760: Add additionalHeader support #1490
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@sfc-gh-vkatardjiev Do we need any security review here? cc: @sfc-gh-hchaturvedi @sfc-gh-skumbham |
None of the headers (or JSON fields) are new from the receiving REST API point of view. All this data can be populated using a Since we're not exposing any new functionality over the network API layer, I don't see a cause for sec review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarQube Quality Gate |
Overview
SNOW-862760
This adds the ability to send optional headers from the util methods.
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist