Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-862760: Add additionalHeader support #1490

Merged

Conversation

sfc-gh-vkatardjiev
Copy link
Collaborator

@sfc-gh-vkatardjiev sfc-gh-vkatardjiev commented Jul 28, 2023

Overview

SNOW-862760

This adds the ability to send optional headers from the util methods.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-vkatardjiev sfc-gh-vkatardjiev self-assigned this Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-vkatardjiev
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-vkatardjiev sfc-gh-vkatardjiev marked this pull request as ready for review July 31, 2023 15:43
@sfc-gh-vkatardjiev sfc-gh-vkatardjiev requested a review from a team as a code owner July 31, 2023 15:43
@sfc-gh-igarish sfc-gh-igarish requested a review from a team August 10, 2023 17:55
@sfc-gh-igarish
Copy link
Collaborator

@sfc-gh-vkatardjiev Do we need any security review here? cc: @sfc-gh-hchaturvedi @sfc-gh-skumbham

@sfc-gh-vkatardjiev
Copy link
Collaborator Author

@sfc-gh-vkatardjiev Do we need any security review here? cc: @sfc-gh-hchaturvedi @sfc-gh-skumbham

None of the headers (or JSON fields) are new from the receiving REST API point of view. All this data can be populated using a curl on any computer connected on the Internet. All snowsight-originated data is validated so that it cannot be spoofed.

Since we're not exposing any new functionality over the network API layer, I don't see a cause for sec review.

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-vkatardjiev sfc-gh-vkatardjiev merged commit dd30019 into master Aug 14, 2023
12 checks passed
@sfc-gh-vkatardjiev sfc-gh-vkatardjiev deleted the vkatardjiev-SNOW-862760-add-header-forwarding branch August 14, 2023 19:04
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants