Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-878076: Retry Strategy for JDBC #1548

Merged
merged 10 commits into from
Nov 6, 2023
Merged

SNOW-878076: Retry Strategy for JDBC #1548

merged 10 commits into from
Nov 6, 2023

Conversation

sfc-gh-ext-simba-jf
Copy link
Collaborator

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf commented Oct 31, 2023 •
edited
Loading

Overview

SNOW-878076: Retry Strategy for JDBC

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/577

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Implementing new retry strategy for login related endpoints.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf requested a review from a team as a code owner October 31, 2023 11:38
sfc-gh-igarish
sfc-gh-igarish approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure it's inline with ODBC implementation.

@sfc-gh-ext-simba-jf
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

sfc-gh-igarish
sfc-gh-igarish approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost
Copy link

ghost commented Nov 3, 2023

@sfc-gh-ext-simba-jf Please add test case for newly added connection parameter retryTimeout if you haven't do so.

ghost
ghost approved these changes Nov 3, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate SonarQubeMergeGate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf merged commit 29771d7 into master Nov 6, 2023
15 of 16 checks passed
@sfc-gh-ext-simba-jf sfc-gh-ext-simba-jf deleted the SNOW-878076-Retry-Strategy-for-JDBC branch November 6, 2023 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-ext-simba-jf @sfc-gh-igarish @sfc-gh-dstempniak