NO-SNOW: Preserve the old data type that goes into an ARRAY column for Schematization #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tzhang
requested review from
sfc-gh-japatel,
sfc-gh-tjones,
sfc-gh-rcheng and
a team
as code owners
sfc-gh-xhuang
approved these changes
Oct 20, 2023
cchandurkar
approved these changes
Oct 21, 2023
|
#711 is also good to fork and merge |
|
@sfc-gh-tzhang |
that should be a different PR? I don't think we have verified whether that will be a behavior change or not |
Yes |
|
Hey any estimates on merging this? Will this be available in next release? |
sfc-gh-rcheng
approved these changes
Nov 2, 2023
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
…r Schematization (snowflakedb#730) Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"] Forked from snowflakedb#727, with additional tests
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
…r Schematization (snowflakedb#730) Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"] Forked from snowflakedb#727, with additional tests
khsoneji
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Dec 4, 2023
…r Schematization (snowflakedb#730) Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"] Forked from snowflakedb#727, with additional tests
EduardHantig
pushed a commit
to streamkap-com/snowflake-kafka-connector
that referenced
this pull request
Feb 1, 2024
…r Schematization (snowflakedb#730) Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"] Forked from snowflakedb#727, with additional tests
sudeshwasnik
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Feb 16, 2024
…r Schematization (snowflakedb#730) Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"] Forked from snowflakedb#727, with additional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, every element in the array will be added as a STRING, this change preserves the old data type in the source, for example when the input is [1, 2], the ingested value will be [1, 2] now instead of ["1", "2"]
Forked from #727, with additional tests