SNOW-1229108 Refactor config validation #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import java.util.Map; | ||
|
|
||
| public interface IConnectorConfigValidator { |
There was a problem hiding this comment.
do we need to follow here the "I" interface naming convention? I would just do as usual with the implementation having postfix Impl or prefix Main/Default
There was a problem hiding this comment.
Changed to Default prefix. We should align to one convention as right now we have no interfaces = no convention ;)
|
Closing - will post another PR with complete change |
auto-merge was automatically disabled
August 1, 2024 14:33
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-1229108
Initial refactor: