Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1514185 Assign new channel when no offset is present in Snowflake #913

Merged
merged 1 commit into from
Aug 20, 2024
Merged

SNOW-1514185 Assign new channel when no offset is present in Snowflake #913

merged 1 commit into from
Aug 20, 2024

Conversation

sfc-gh-lshcharbaty
Copy link
Contributor

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty commented Aug 19, 2024 •
edited
Loading

Overview

SNOW-1514185
Addressing this comment and assigning a reopened channel even when no offset is present in Snowflake.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty requested a review from a team as a code owner August 19, 2024 08:26
@sfc-gh-lshcharbaty sfc-gh-lshcharbaty force-pushed the lshcharbaty/SNOW-1514185_Assign_channel_when_no_offset_in_snowflake branch from e9106f9 to 77b3eb1 Compare August 19, 2024 08:30
sfc-gh-tzhang
sfc-gh-tzhang approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@sfc-gh-lshcharbaty sfc-gh-lshcharbaty merged commit b68d226 into master Aug 20, 2024
80 checks passed
@sfc-gh-lshcharbaty sfc-gh-lshcharbaty deleted the lshcharbaty/SNOW-1514185_Assign_channel_when_no_offset_in_snowflake branch August 20, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-tzhang sfc-gh-tzhang sfc-gh-tzhang approved these changes

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-lshcharbaty @sfc-gh-tzhang @sfc-gh-mbobowski