Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW Ignore major updates on Kafka dependencies #915

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

Overview

NO-SNOW Ignore major updates on Kafka dependencies

Dependabot gets confused with Confluent Kafka versioning and wants to update to community edition like here. Preventing major updates should stop this behavior because ce / cs updates are not present in 3.x.x (source)

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

Copy link

@sfc-gh-dseweryn sfc-gh-dseweryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that there may be a better way to make dependabot what we want but apparently there is no easy way. We should probably spend the time elsewhere. Question though — how will we keep the kafka updated? There are already versions 3.7.1 and 3.8.0 available.

@sfc-gh-mbobowski
Copy link
Contributor Author

I was thinking that there may be a better way to make dependabot what we want but apparently there is no easy way. We should probably spend the time elsewhere. Question though — how will we keep the kafka updated? There are already versions 3.7.1 and 3.8.0 available.

@sfc-gh-dseweryn not sure if I understand your question. The dependabot will keep track of the new Kafka releases that are not major so basically anything 3.x.y is valid.

@sfc-gh-dseweryn
Copy link

There are already versions 3.7.1 and 3.8.0 available.

This was only a side-note that we're not on top of the available versions.
I meant that if 4.0.0 will be released we won't notice

@sfc-gh-mbobowski
Copy link
Contributor Author

There are already versions 3.7.1 and 3.8.0 available.

This was only a side-note that we're not on top of the available versions. I meant that if 4.0.0 will be released we won't notice

That's true we have to track it on our own.

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit d55cd76 into master Aug 21, 2024
78 of 80 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-NO-SNOW-ignore-dependabot-kafka branch August 21, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants