SNOW-1649161 Fix NaN value handling in schematization #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mbobowski
force-pushed
the
mbobowski-SNOW-1649161
branch
4 times, most recently
from
9d85b23
to
62ab727
Compare
sfc-gh-mbobowski
commented
Sep 6, 2024
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| public class SnowflakeSinkServiceV2AvroSchematizationIT { |
There was a problem hiding this comment.
The logic of this test is the same as before with added NaN field. A couple of things I fixed here:
- Use String constants to avoid typos
- Use awaitility instead of custom code
- Use
StringUtils.deleteWhitespaceinstead of custom code - Use JUnit assertions instead of assert
- Use Junit
@BeforeEach/@AfterEach - Restructure the code to have a given / when / then
- Move test data to test class
- Make assertion explicit (if you have doubts take a look at what happens in
checkTableContentOneRow())
So while it still can be better please keep your review bar at reasonable level here :)
sfc-gh-mbobowski
commented
Sep 6, 2024
| @@ -204,6 +204,5 @@ if [ $testError -ne 0 ]; then | |||
| RED='\033[0;31m' | |||
| NC='\033[0m' # No Color | |||
| echo -e "${RED} There is error above this line ${NC}" | |||
| cat $APACHE_LOG_PATH/kc.log | |||
There was a problem hiding this comment.
Not sure if we need it at all. Printing 10k log lines might be useful in CI but for local development it makes things worse.
sfc-gh-mbobowski
force-pushed
the
mbobowski-SNOW-1649161
branch
from
62ab727
to
2d2fda9
Compare
sfc-gh-mbobowski
changed the title
sfc-gh-gjachimko
approved these changes
Sep 6, 2024
sfc-gh-wtrefon
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1649161
Special floating point value
NaNwas causing exception with schematization enabled. The reason for this failure was parsing data to an intermediate JsonNode format and then callingwriteValueAsStringwhich returned""NaN"".This PR contains:
NaNworking in Snowpipe / Snowpipe Streaming ingestionPre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected