SNOW-1658905 Limit SnowflakeSinkConnectorConfig responsibilities #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mbobowski
force-pushed
the
mbobowski-SNOW-1658905-refactor
branch
from
db47ffa
to
0eb0894
Compare
sfc-gh-mbobowski
changed the title
sfc-gh-mbobowski
changed the title
| @Override | ||
| public void ensureValid(String name, Object value) { | ||
| assert value instanceof String; | ||
| final String strValue = (String) value; |
There was a problem hiding this comment.
should we assert on instance of string?
There was a problem hiding this comment.
It's copied. Even if it's wrong I don't want to change anything within this PR.
| public TopicToTableValidator() {} | ||
|
|
||
| public void ensureValid(String name, Object value) { | ||
| String s = (String) value; |
There was a problem hiding this comment.
Same as above :)
| // validate REST API is called | ||
| @Override | ||
| public void ensureValid(String name, Object value) { | ||
| assert value instanceof String; |
There was a problem hiding this comment.
I think the use of assert is a legacy part that we should get rid of. Since we cannot enforce that they are enabled at runtime, we assume they can be disabled.
There was a problem hiding this comment.
Yes, but not in the same PR as refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-1658905 Initial config refactor
SnowflakeSinkConnectorConfigclass has a lot of responsibilities:This PR extracts some parts of this class to dedicated files. There are still many other things to be fixed around config but this is a 1 hour of work that gives some effect.
Pre-review checklist
snowflake.ingestion.method.Yes- Added end to end and Unit Tests.No- Suggest why it is not param protected