Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW Enable closing channels in parallel by default #928

Merged
merged 1 commit into from
Sep 19, 2024
Merged

NO-SNOW Enable closing channels in parallel by default #928

merged 1 commit into from
Sep 19, 2024

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Sep 19, 2024 •
edited
Loading

Overview

There was no errors reported about closing channels in parallel and we know it's way faster. Let's enable it.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner September 19, 2024 09:38
@sfc-gh-mbobowski sfc-gh-mbobowski enabled auto-merge (squash) September 19, 2024 09:51
sfc-gh-wtrefon
sfc-gh-wtrefon approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-wtrefon sfc-gh-wtrefon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-mbobowski sfc-gh-mbobowski merged commit 7e93503 into master Sep 19, 2024
77 of 78 checks passed
@sfc-gh-mbobowski sfc-gh-mbobowski deleted the mbobowski-NO-SNOW-close-channels-in-parallel branch September 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-wtrefon