Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1658905 Integration tests setup for Iceberg #930

Merged
merged 6 commits into from
Sep 20, 2024
Merged

SNOW-1658905 Integration tests setup for Iceberg #930

merged 6 commits into from
Sep 20, 2024
+184 −36

Conversation

sfc-gh-mbobowski
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski commented Sep 20, 2024 •
edited
Loading

Overview

SNOW-1658905

While the IcebergTableSchemaValidator is WIP the test setup and base test class will be useful for @sfc-gh-wtrefon to work in parallel on Iceberg.

Note - this PR has zero effect on the production code as.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-mbobowski sfc-gh-mbobowski requested a review from a team as a code owner September 20, 2024 10:44
sfc-gh-mbobowski
sfc-gh-mbobowski commented Sep 20, 2024
View reviewed changes
src/test/java/com/snowflake/kafka/connector/internal/TestUtils.java
* @throws Exception when meeting error
*/
private static Connection getConnection() throws Exception {
if (conn != null) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this was the only usage of the conn, so it was never initialized...

sfc-gh-wtrefon
sfc-gh-wtrefon approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-wtrefon sfc-gh-wtrefon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-wtrefon sfc-gh-wtrefon merged commit 64e6f24 into master Sep 20, 2024
76 of 78 checks passed
@sfc-gh-wtrefon sfc-gh-wtrefon deleted the mbobowski-SNOW-1658905-table-validations branch September 20, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-wtrefon sfc-gh-wtrefon sfc-gh-wtrefon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mbobowski @sfc-gh-wtrefon