Fix UBSAN reported access to kernel_dirent withing misaligned address

This is can be an issue on ARM, it can cause a hang of CrashReportTest.MiniDump test on macOS.
snxd · Aug 6, 2024 · 381ed41 · 381ed41
1 parent ff38335
commit 381ed41
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/client/linux/minidump_writer/directory_reader.h b/src/client/linux/minidump_writer/directory_reader.h
@@ -95,9 +95,10 @@ class DirectoryReader {
 
  private:
   const int fd_;
-  bool hit_eof_;
   unsigned buf_used_;
-  uint8_t buf_[sizeof(struct kernel_dirent) + NAME_MAX + 1];
+  alignas(struct kernel_dirent)
+      uint8_t buf_[sizeof(struct kernel_dirent) + NAME_MAX + 1];
+  bool hit_eof_;
 };
 
 }  // namespace google_breakpad