-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added required permissions in the action example #79
base: master
Are you sure you want to change the base?
Conversation
I had to add other permissions in order to get them to actually work:
|
Hi, Just pointing out that this PR is quite important IMO, I've been struggling with permissions and couldn't find anything to help me in all of Snyk docs, so this change would probably very much appreciated! thanks for the great project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening a PR, please rebase & re-run the generator, then we can merge this in 👍
Why is there no Issues tab on this repo? Is the PR area the only place where we can tell you that things don't work? |
Sorry to hijack this PR for my issue. I just don't see where to report problems for this repo. Has anyone been able to get the
even though my SNYK_TOKEN secret is set in the repo and I have:
This used to work months ago, but it's stopped working for months now. (And I'm wondering if Snyk has CI on their own actions 😄 ) |
@huyz Please reach out to Snyk Support on that, as it's an official channel providing customer support. |
@michelkaporin thank you for the feedback! I missed your comment, just regenerated everything |
@danacr @snyk/hammerhead should take care of your PR, as I moved to a different team at Snyk. I've pinged them to re-review it. |
I had the same issue and moved the SNYK_TOKEN to the global scope. It all worked after that. |
hey folks, can we merge this? |
The action example will fail without setting the read permission for the repository and the security events write for the Sarif file.