chore: include region value in output #5604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisislawatts
force-pushed
the
CLI-568/include-region-alias-in-output
branch
from
927ee05 to
af90306
Compare
thisislawatts
force-pushed
the
CLI-568/include-region-alias-in-output
branch
from
af90306 to
0cd9208
Compare
j-luong
reviewed
Nov 28, 2024
| @@ -109,6 +110,12 @@ func writeLogHeader(config configuration.Configuration, networkAccess networking | |||
| tablePrint("Version", cliv2.GetFullVersion()+" "+buildType) | |||
| tablePrint("Platform", userAgent) | |||
| tablePrint("API", config.GetString(configuration.API_URL)) | |||
|
|
|||
| region, err := localworkflows.DetermineRegionFromUrl(config.GetString(configuration.API_URL)) | |||
There was a problem hiding this comment.
nitpick: I know we handle the error in GAF, but in general I'm not sure I'm convinced of this pattern of assuming errors are handled in the dependencies.
I would suggest:
if err != nil {
...
} else {
...
}
but it's a minor point
j-luong
approved these changes
Nov 28, 2024
j-luong
force-pushed
the
CLI-568/include-region-alias-in-output
branch
from
0cd9208 to
402a8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Introduces a Region key to our debug output to make it quicker to troubleshoot the region we are currently configured to run against.
Associated documentation: https://docs.snyk.io/working-with-snyk/regional-hosting-and-data-residency#available-snyk-regions
How should this be manually tested?
snyk config environment defaultsnyk help -dThe output will include Region: snyk-us-01snyk config environment devsnyk help -dwill not include a Region property as we are running against a dev instance.Expected Output