feat: telemetry and compareFrom removal (#605)

* removed compareTo as we already expose the base flag.
* added Telemetry - off for non CI builds

src/__tests__/lint.test.ts

@@ -42,13 +42,12 @@ describe("lint command", () => {
   );
 
   it(
-    "can lint with with --compare-to and --compare-from",
+    "can lint with with --compare-to",
     async () => {
       try {
         process.chdir("end-end-tests/api-standards");
         await lintAction(undefined, undefined, {
           compareTo: "HEAD",
-          compareFrom: "main",
         });
       } catch (err) {
         fail(err);

src/lint.ts

@@ -97,10 +97,9 @@ export const lintAction = async (
         );
         continue;
       }
-      const base =
-        options?.compareFrom ??
-        linter["optic-ci"]?.original ??
-        defaultBranchName;
+
+      const base = linter["optic-ci"]?.original ?? defaultBranchName;
+
       await expectGitBranch(base);
       await bulkCompare(
         path.join(path.relative(topDir, vervetConfDir), resource.path),
@@ -124,11 +123,6 @@ export const createLintCommand = () => {
       "--compare-to <compare-to>",
       "the head ref to compare against. Defaults to the current working directory",
     )
-    .option(
-      "--compare-from <compare-from>",
-      "the base ref to compare against. Defaults to MAIN",
-      "main",
-    )
     .action(lintAction);
   command.description("lint APIs in current project");
   return command;
@@ -161,10 +155,13 @@ const bulkCompare = async (
     ...extraArgs,
   ];
   return new Promise<void>((resolve, reject) => {
+    const env = { ...process.env };
+    if (!process.env.CI) {
+      env.OPTIC_TELEMETRY_LEVEL = "off";
+    }
+
     const child = child_process.spawn(process.argv0, args, {
-      env: {
-        ...process.env,
-      },
+      env: env,
       stdio: "inherit",
     });
     child.on("error", (err) => {