Skip to content

Commit

Permalink
feat: revert to node18
Browse files Browse the repository at this point in the history
* feat: revert to node18
  • Loading branch information
corneliu-petrescu authored Mar 22, 2024
1 parent 649b07f commit 7c44956
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ orbs:
defaults: &defaults
resource_class: small
docker:
- image: cimg/node:20.11
- image: cimg/node:18.18
working_directory: ~/sweater-comb

commands:
Expand Down
6 changes: 3 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
FROM node:20.11-alpine AS build-env
FROM node:18.18.2-alpine3.18 AS build-env
WORKDIR /sweater-comb
COPY ["package.json", "package-lock.json", "./"]
RUN npm ci
COPY . .
RUN npm run build

FROM node:20.11-alpine AS clean-env
FROM node:18.18.2-alpine3.18 AS clean-env
COPY --from=build-env /sweater-comb/build/ /sweater-comb/
COPY --from=build-env /sweater-comb/babel.config.js /sweater-comb/
COPY --from=build-env /sweater-comb/package*.json /sweater-comb/
WORKDIR /sweater-comb
RUN npm install --production

FROM node:20.11-alpine
FROM node:18.18.2-alpine3.18
ENV NODE_ENV production
COPY --from=clean-env /sweater-comb/ /sweater-comb/
WORKDIR /sweater-comb
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"/schemas"
],
"engines": {
"node": ">=20"
"node": ">=18"
},
"scripts": {
"test": "jest --colors",
Expand Down
3 changes: 2 additions & 1 deletion scripts/build-npm.bash
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ npm pack
export GITHUB_TOKEN=${GITHUB_TOKEN:-$GH_TOKEN}

if [[ -n "$GITHUB_TOKEN" && -n "$NPM_TOKEN" ]]; then
npx "semantic-release@23"
# fix dependency at 22.0.12 untill we find workaround for node20 requirement
npx "semantic-release@22.0.12"
fi

0 comments on commit 7c44956

Please sign in to comment.