Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Makerdiary nRF52840 MDK dongle #46

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add support for Makerdiary nRF52840 MDK dongle #46

wants to merge 9 commits into from

Conversation

Brezensalzer
Copy link

Digital Pins, I2C, SPI, Serial (USB) and OpenThread was successfully tested.
Thank You for Your support!

@soburi
Copy link
Owner

soburi commented Jan 28, 2022

@Brezensalzer
Could you push this patch into the upstream repository ?

This PR is useful for not only my openthread enabled arduino.
so It is better to push upstream.

(In actual, I maintain this project with mainly merge upstream updates only. It will keep world peace if you push to upstream project. :-)

I wrote any I noticed to the PR review.

soburi
soburi reviewed Jan 28, 2022
View reviewed changes
boards.txt
@@ -16,7 +16,7 @@
# License along with this library; if not, write to the Free Software
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA

menu.softdevice=SoftDevice
menu.softdevice=Bootloader
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it need to change?

boards.txt Outdated
@@ -57,7 +57,7 @@ feather52840.build.vid=0x239A
feather52840.build.pid=0x8029

# SofDevice Menu
feather52840.menu.softdevice.s140v7=S140 7.0.1
feather52840.menu.softdevice.s140v7=0.3.2 SoftDevice s140 7.0.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

soburi
soburi reviewed Jan 29, 2022
View reviewed changes
variants/mdk_nrf52840/variant.h Outdated
static const uint8_t A1 = PIN_A1 ;
static const uint8_t A2 = PIN_A2 ;
static const uint8_t A3 = PIN_A3 ;
static const uint8_t A4 = PIN_A0 ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

A4 = PIN_A4

boards.txt Outdated

# VID/PID for bootloader with/without UF2, Arduino + Circuitpython App
mdk52840.vid.0=0x239A
mdk52840.pid.0=0x80DD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation: Where did the values 0x80DD and 0x802A come from? (I couldn't found in the bootloader source.)

@Brezensalzer
Copy link
Author

Hello soburi,
when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that.
I have also fixed the analog pin definition.

This PR is useful for not only my openthread enabled arduino.
so It is better to push upstream.

You have a point there. I will make a pull request on the upstream Adafruit repository.
Thank You for Your support!

@soburi
Copy link
Owner

soburi commented Jan 31, 2022

@Brezensalzer ,

You have a point there. I will make a pull request on the upstream Adafruit repository.

That's good!
Since I'm watching the upstream repository, I will quickly apply the changes once it merges into the upstream.

when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that.

hmm... I think it's better to remove it.
(I'm not sure if the CircuitPython package supports a 'use_1200bps_touch' to flash. It is good to consult to upstream project when push.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soburi soburi soburi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brezensalzer @soburi