Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not invoke failed rows API when no failed rows #2105

Closed
wants to merge 4 commits into from
Closed

Do not invoke failed rows API when no failed rows #2105

wants to merge 4 commits into from

Conversation

jzalucki
Copy link
Contributor

No description provided.

@jzalucki jzalucki requested a review from m1n0 June 25, 2024 21:35
@jzalucki jzalucki self-assigned this Jun 25, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jarosław Załucki seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

m1n0
m1n0 requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@m1n0 m1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the mock request/response setup that might be useful for other stuff later.

I only had one small suggestion for the mock sampler enable

soda/core/tests/helpers/test_scan.py Outdated Show resolved Hide resolved
@jzalucki jzalucki requested a review from m1n0 June 26, 2024 08:36
@jzalucki jzalucki marked this pull request as ready for review June 26, 2024 08:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@m1n0 m1n0 enabled auto-merge (squash) June 27, 2024 00:31
@jzalucki
Copy link
Contributor Author

License/CLA problem branch recreated CLOUD-7845/http-no-failed-rows-

@jzalucki jzalucki closed this Jun 27, 2024
auto-merge was automatically disabled June 27, 2024 09:04

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1n0 m1n0 m1n0 approved these changes

Assignees

@jzalucki jzalucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzalucki @CLAassistant @m1n0