-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify custom hostname for Snowflake connection #2109
Conversation
hi @whummer, thanks for this, it's an interesting use case! It is a minor change and I don't feel like we need to cover it by test, but I see one issue - I would only pass the host/port if value is present, we do not want to force everyone to start specifying host with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please pass the host/port only if present to endure backward compatibility.
Good point, thanks @m1n0 (although I think the Snowflake Python connector would also be able to handle Updated the PR to pass in keyword arguments ( |
Hi @m1n0 , wanted to briefly follow up on this PR here. Do the changes look good to you, anything else you'd like me to add to the PR? Would be awesome to get this one merged, so we can further promote Soda to our LocalStack user base! 🙌 🚀 |
@whummer could you please rename the dict from |
Done @m1n0 - renamed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contrib!
Thanks for the review @m1n0 ! Looks like the last CI run failed with the following error:
This error seems unrelated to the changes in this PR, 🤔 do you have any advice? I've rebased the branch onto latest |
The reason snowflake and BQ tests failed is that non-mainteiner issued PRs do not have access to repository secrets for security reasons, it's fine I merged it |
Add ability to specify custom
host
/port
for Snowflake connections.Motivation: At LocalStack, we have recently started building a Snowflake emulator that allows running SF queries entirely on the local machine: https://blog.localstack.cloud/2024-05-22-introducing-localstack-for-snowflake/ . As part of building out a repo with sample applications (see here), we are putting together an illustrative Soda application that connects to the local Snowflake emulator (running on
localhost
) and performs various data quality checks.We have been able to get it working already by manually patching the
soda-core
library in the local Pyhon path.... and then:
It would be awesome if this integration was provided by Soda-core out of the box! Looking forward to getting your feedback.
Please let me know where is the best place to add a description for these new attributes (happy to add a short note in the docs), or if this change should be covered by a unit test. Thanks 🙌
/cc @m1n0