Refactor getVersionFromToolVersionsFile function #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayoub-Mabrouk
commented
Nov 5, 2024
Ayoub-Mabrouk
commented
- Simplified parameter handling by providing a default value directly in the function signature.
- Improved readability by removing unnecessary variable assignment.
- Simplified parameter handling by providing a default value directly in the function signature. - Improved readability by removing unnecessary variable assignment.
mkaput
requested changes
Nov 5, 2024
| @@ -106,14 +106,13 @@ function fetchLatestTag(repo) { | |||
| ); | |||
| } | |||
|
|
|||
| async function getVersionFromToolVersionsFile(toolVersionsPath) { | |||
| async function getVersionFromToolVersionsFile(toolVersionsPath = ".tool-versions") { | |||
There was a problem hiding this comment.
same story as in #28: this code doesn't cover this case:
"" || "foo" == "foo"which we actually need, as it is pretty easy to declare the input but not set it in yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.