fix #164 #168
Merged
fix #164 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ished with IE or not
…terrupted exception
hearnadam
reviewed
Jul 1, 2024
core/src/main/scala/ox/fork.scala
Outdated
Comment on lines
181
to
182
| override def wasInterruptedWith(ie: InterruptedException): Boolean = | ||
| result.isCompletedExceptionally && (result.exceptionNow() eq ie) |
There was a problem hiding this comment.
Does this need to be public? it seems like it has the potential to be misused given the eq check.
There was a problem hiding this comment.
yeah, we discussed that in the issue, it's package private now.
|
Nope, let me push the commit :)
…On Mon 1. Jul 2024 at 18:15, Adam Hearn ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/src/main/scala/ox/fork.scala
<#168 (comment)>:
> + override def wasInterruptedWith(ie: InterruptedException): Boolean =
+ result.isCompletedExceptionally && (result.exceptionNow() eq ie)
Does this need to be public? it seems like it has the potential to be
misused given the eq check.
—
Reply to this email directly, view it on GitHub
<#168 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBVNUX2GTL7DFHH7S4GNA3ZKF6ATAVCNFSM6AAAAABKDO6436VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJRG43TCNRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fork#joinEither aware whether fork finished with InterruptedException or not. Also adds sbt settings that greatly improve debugging of race conditions (because one can interrupt a forked jvm instead of killing sbt jvm).