feat: implement drop function
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Oct 16, 2023
| class SourceOpsDropTest extends AnyFlatSpec with Matchers { | ||
| behavior of "Source.drop" | ||
|
|
||
| it should "not drop from the empty source" in scoped { |
There was a problem hiding this comment.
let's use supervised where possible; it should be our "default" scoping tool, unless some specific requirements necessitate usage of scoped
adamw
reviewed
Oct 16, 2023
| @@ -141,6 +141,24 @@ trait SourceOps[+T] { this: Source[T] => | |||
|
|
|||
| def take(n: Int)(using Ox, StageCapacity): Source[T] = transform(_.take(n)) | |||
|
|
|||
| /** Drops `n` elements from the source and emits any subsequent elements. | |||
There was a problem hiding this comment.
I'd change the wording slightly to indicate that we return a different source than the current one. E.g.:
Drops `n` elements from this source and forwards any subsequent ones to the returned channel.
rucek
reviewed
Oct 17, 2023
| import ox.* | ||
|
|
||
| class SourceOpsDropTest extends AnyFlatSpec with Matchers { | ||
| behavior of "Source.drop" |
There was a problem hiding this comment.
thought: How about an additional test case to verify that drop(0) doesn't drop anything?
Drop `n` elements from the source and emit subsequent elements (if any left) e.g.: Source.empty[Int].drop(1).toList // List() Source.fromValues(1, 2, 3).drop(1).toList // List(2 ,3) Source.fromValues(1).drop(2).toList // List()
geminicaprograms
force-pushed
the
feat_drop
branch
from
ea8a9c3 to
d738f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop
nelements from the source and emit subsequent elements (if any left) e.g.: