feat: implement dropWhile function
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geminicaprograms
force-pushed
the
feat_dropWhile
branch
from
b7b1702 to
77a9a8c
Compare
kciesielski
approved these changes
Oct 17, 2023
kciesielski
reviewed
Oct 17, 2023
| import ox.* | ||
|
|
||
| class SourceOpsDropWhileTest extends AnyFlatSpec with Matchers { | ||
| behavior of "Source.drop" |
| s.dropWhile(_ > 0).toList shouldBe List.empty | ||
| } | ||
|
|
||
| it should "drop elements from the source while predicate is true" in scoped { |
There was a problem hiding this comment.
suggestion: If I understand correctly in Adam's review to another PR, scoped should be replaced with supervised
rucek
approved these changes
Oct 17, 2023
geminicaprograms
force-pushed
the
feat_dropWhile
branch
2 times, most recently
from
f9bd0b1 to
0b4455e
Compare
geminicaprograms
force-pushed
the
feat_drop
branch
from
ea8a9c3 to
d738f3d
Compare
Drops elements from the source as long as the predicate is satisfied. Note the if predicate fails then subsequent elements are no longer dropped even if they could still satisfy it. Examples: Source.empty[Int].dropWhile(_ > 3).toList // List() Source.fromValues(1, 2, 3).dropWhile(_ < 3).toList // List(3) Source.fromValues(1, 2, 1).dropWhile(_ < 2).toList // List(2, 1)
geminicaprograms
force-pushed
the
feat_dropWhile
branch
from
0b4455e to
5f66d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops elements from the source as long as the predicate is satisfied. Note that if the predicate fails then subsequent elements are no longer dropped even if they could still satisfy it.
Examples: