feat: implement takeWhile function
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Oct 16, 2023
| @@ -141,6 +141,25 @@ trait SourceOps[+T] { this: Source[T] => | |||
|
|
|||
| def take(n: Int)(using Ox, StageCapacity): Source[T] = transform(_.take(n)) | |||
|
|
|||
| /** Takes elements from the source as long as predicate `f` is satisfied (returns `true`). Note that once the predicate `f` is not | |||
There was a problem hiding this comment.
Same as in the others - I would change the wording a bit to indicate that the returned source is a separate one. E.g. Forwards the elements from this source to the return one, as along ...
There was a problem hiding this comment.
We're using "sends to the returned channel" in other operators, so let's use a similar wording here for consistency from the user's perspective.
Sends elements to the returned channel until predicate is satisfied. Note that if the predicate fails then subsequent elements are not longer taken even if they could still satisfy it. Example: Source.empty[Int].takeWhile(_ > 3).toList // List() Source.fromValues(1, 2, 3).takeWhile(_ < 3).toList // List(1, 2) Source.fromValues(3, 2, 1).takeWhile(_ < 3).toList // List()
geminicaprograms
force-pushed
the
feat_takeWhile
branch
from
379cd29 to
0b4455e
Compare
|
Sorry, needs merge |
adamw
approved these changes
Oct 17, 2023
Fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes elements from the source as long as the predicate is satisfied. Note that if the predicate fails then subsequent elements are not longer taken even if they could still satisfy it.
Example: