-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe governance and restructure website and repo scopes #295
base: develop
Are you sure you want to change the base?
Conversation
@softwarepub/core and @softwarepub/hermes-steering-group Please review, especially carefully for |
Co-authored-by: David Pape <d.pape@hzdr.de>
…:softwarepub/hermes into feature/287-governance-website-structure
I'm not a fan of this phrasing because it can contradict in certain cases the rules laid out in GOVERNANCE.md 🤷🏻♂️ |
Huh, interesting automatism. Let me check if there is a switch I can flip so that this doesn't appear. I can't see how I'd have triggered this through review invitations. In any case, this change is critical enough to warrant more thorough reviews, calling @led02, @poikilotherm, @nheeb. |
@zyzzyxdonta Yea, this seems to have been triggered through the invitation of the group. These are the options for the team setup and code review: At least option 2 seems to make sense in our case? And perhaps option 1 on top? |
2 makes sense, yes. 1 not so much. If I assign the steering group I want all of them to see it, no matter if I "accidentally" select one of its members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question that needs to be discussed is, how to change these rules? Maybe all maintainers need to consent?
Other than that and the inline comments, I would have loved to see an issue for the website/ project part.
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
Co-authored-by: Michael Meinel <michael.meinel@dlr.de>
Co-authored-by: Sophie <133236526+SKernchen@users.noreply.github.com>
@poikilotherm & @nheeb Last call for reviews! I think this has had enough eyes on it for now, so if there are no vetoes, I'll merge in the week of 13 Jan. |
Fix #287