Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash When The file path cannot create the file #2919

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

keenlovelife
Copy link

@keenlovelife keenlovelife commented Sep 10, 2021

Crash When The file path cannot be used by Windows to create the file

system: Windows 10 x64

debug

$ you-get https://www.bilibili.com/video/BV1YK4y1T7yY?p=10 --debug
[DEBUG] get_content: https://www.bilibili.com/video/BV1YK4y1T7yY?p=10
[DEBUG] get_content: https://www.bilibili.com/video/BV1YK4y1T7yY?p=10
you-get: This is a multipart video. (use --playlist to download all parts.)

[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=112&quality=112&type=&sign=ea6333c13d28a31b4a
088bec9135a1d6
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=80&quality=80&type=&sign=afc765bddbc693d32bb3
39ea35342abc
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=64&quality=64&type=&sign=ca1ffdb989a2ae7868af
e7e95e3a6a55
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=32&quality=32&type=&sign=0b52c496684dae880bc8
e530a453dcaf
[DEBUG] get_content: https://api.bilibili.com/x/player/playurl?avid=887241709&ci
d=335498504&qn=16&type=&otype=json&fnver=0&fnval=16&fourk=1
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=16&quality=16&type=&sign=0a96b6a36645d4400fdd
6cf0c02a7e18
[DEBUG] get_content: http://comment.bilibili.com/335498504.xml
site:                Bilibili
title:               GAMES202-高质量实时渲染 (P10. Lecture10 Real-Time Physicall
y-based Materials(surface models))
stream:
    - format:        dash-flv720
      container:     mp4
      quality:       高清 720P
      size:          199.5 MiB (209239665 bytes)
    # download-with: you-get --format=dash-flv720 [URL]

Downloading GAMES202-高质量实时渲染 (P10. Lecture10 Real-Time Physically-based M
aterials(surface m.mp4 ...
 0.0% (  0.0/199.5MB) ├────────────────────────────────────────┤[1/2] you-get: v
ersion 0.4.1545, a tiny downloader that scrapes the web.
you-get: Namespace(version=False, help=False, info=False, url=False, json=False,
 no_merge=False, no_caption=False, force=False, skip_existing_file_size_check=Fa
lse, format=None, output_filename=None, output_dir='.', player=None, cookies=Non
e, timeout=600, debug=True, input_file=None, password=None, playlist=False, firs
t=None, last=None, size=None, auto_rename=False, insecure=False, http_proxy=None
, extractor_proxy=None, no_proxy=False, socks_proxy=None, stream=None, itag=None
, URL=['https://www.bilibili.com/video/BV1YK4y1T7yY?p=10'])
Traceback (most recent call last):
  File "D:\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "D:\Python39\Scripts\you-get.exe\__main__.py", line 7, in <module>
  File "D:\Python39\lib\site-packages\you_get\__main__.py", line 92, in main
    main(**kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1831, in main
    script_main(any_download, any_download_playlist, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1713, in script_m
ain
    download_main(
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1345, in download
_main
    download(url, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1822, in any_down
load
    m.download(url, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\extractor.py", line 61, in downloa
d_by_url
    self.download(**kwargs)
  File "D:\Python39\lib\site-packages\you_get\extractor.py", line 238, in downlo
ad
    download_urls(urls, self.title, ext, total_size, headers=headers,
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1022, in download
_urls
    url_save(
  File "D:\Python39\lib\site-packages\you_get\common.py", line 771, in url_save
    with open(temp_filepath, open_mode) as output:
OSError: [Errno 22] Invalid argument: '.\\GAMES202-高质量实时渲染 (P10. Lecture1
0 Real-Time Physically-based Materials\x03(surface m[00].mp4.download'

Crash When The file path cannot be used by Windows to create the file

debug
```
$ you-get https://www.bilibili.com/video/BV1YK4y1T7yY?p=10 --debug
[DEBUG] get_content: https://www.bilibili.com/video/BV1YK4y1T7yY?p=10
[DEBUG] get_content: https://www.bilibili.com/video/BV1YK4y1T7yY?p=10
you-get: This is a multipart video. (use --playlist to download all parts.)

[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=112&quality=112&type=&sign=ea6333c13d28a31b4a
088bec9135a1d6
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=80&quality=80&type=&sign=afc765bddbc693d32bb3
39ea35342abc
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=64&quality=64&type=&sign=ca1ffdb989a2ae7868af
e7e95e3a6a55
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=32&quality=32&type=&sign=0b52c496684dae880bc8
e530a453dcaf
[DEBUG] get_content: https://api.bilibili.com/x/player/playurl?avid=887241709&ci
d=335498504&qn=16&type=&otype=json&fnver=0&fnval=16&fourk=1
[DEBUG] get_content: https://interface.bilibili.com/v2/playurl?appkey=iVGUTjsxvp
LeuDCf&cid=335498504&otype=json&qn=16&quality=16&type=&sign=0a96b6a36645d4400fdd
6cf0c02a7e18
[DEBUG] get_content: http://comment.bilibili.com/335498504.xml
site:                Bilibili
title:               GAMES202-高质量实时渲染 (P10. Lecture10 Real-Time Physicall
y-based Materials(surface models))
stream:
    - format:        dash-flv720
      container:     mp4
      quality:       高清 720P
      size:          199.5 MiB (209239665 bytes)
    # download-with: you-get --format=dash-flv720 [URL]

Downloading GAMES202-高质量实时渲染 (P10. Lecture10 Real-Time Physically-based M
aterials(surface m.mp4 ...
 0.0% (  0.0/199.5MB) ├────────────────────────────────────────┤[1/2] you-get: v
ersion 0.4.1545, a tiny downloader that scrapes the web.
you-get: Namespace(version=False, help=False, info=False, url=False, json=False,
 no_merge=False, no_caption=False, force=False, skip_existing_file_size_check=Fa
lse, format=None, output_filename=None, output_dir='.', player=None, cookies=Non
e, timeout=600, debug=True, input_file=None, password=None, playlist=False, firs
t=None, last=None, size=None, auto_rename=False, insecure=False, http_proxy=None
, extractor_proxy=None, no_proxy=False, socks_proxy=None, stream=None, itag=None
, URL=['https://www.bilibili.com/video/BV1YK4y1T7yY?p=10'])
Traceback (most recent call last):
  File "D:\Python39\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Python39\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "D:\Python39\Scripts\you-get.exe\__main__.py", line 7, in <module>
  File "D:\Python39\lib\site-packages\you_get\__main__.py", line 92, in main
    main(**kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1831, in main
    script_main(any_download, any_download_playlist, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1713, in script_m
ain
    download_main(
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1345, in download
_main
    download(url, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1822, in any_down
load
    m.download(url, **kwargs)
  File "D:\Python39\lib\site-packages\you_get\extractor.py", line 61, in downloa
d_by_url
    self.download(**kwargs)
  File "D:\Python39\lib\site-packages\you_get\extractor.py", line 238, in downlo
ad
    download_urls(urls, self.title, ext, total_size, headers=headers,
  File "D:\Python39\lib\site-packages\you_get\common.py", line 1022, in download
_urls
    url_save(
  File "D:\Python39\lib\site-packages\you_get\common.py", line 771, in url_save
    with open(temp_filepath, open_mode) as output:
OSError: [Errno 22] Invalid argument: '.\\GAMES202-高质量实时渲染 (P10. Lecture1
0 Real-Time Physically-based Materials\x03(surface m[00].mp4.download'
```
@soimort-bot
Copy link
Collaborator

Hello @keenlovelife,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants