-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links referring to master branch in README #439
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Nice catch. Some of the repos did not change. Can you help with fixing this?
* Given this [package.yaml](https://github.com/hspec/sensei/blob/master/package.yaml) running `hpack` will generate [sensei.cabal](https://github.com/hspec/sensei/blob/master/sensei.cabal) | ||
* Given this [package.yaml](https://github.com/haskell-compat/base-orphans/blob/master/package.yaml) running `hpack` will generate [base-orphans.cabal](https://github.com/haskell-compat/base-orphans/blob/master/base-orphans.cabal) | ||
* Given this [package.yaml](https://github.com/sol/hpack/blob/main/package.yaml) running `hpack` will generate [hpack.cabal](https://github.com/sol/hpack/blob/main/hpack.cabal) | ||
* Given this [package.yaml](https://github.com/zalora/getopt-generics/blob/main/package.yaml) running `hpack` will generate [getopt-generics.cabal](https://github.com/zalora/getopt-generics/blob/main/getopt-generics.cabal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo still uses master
, albeit the repo itself mas moved to https://github.com/soenkehahn/getopt-generics/.
* Given this [package.yaml](https://github.com/sol/hpack/blob/main/package.yaml) running `hpack` will generate [hpack.cabal](https://github.com/sol/hpack/blob/main/hpack.cabal) | ||
* Given this [package.yaml](https://github.com/zalora/getopt-generics/blob/main/package.yaml) running `hpack` will generate [getopt-generics.cabal](https://github.com/zalora/getopt-generics/blob/main/getopt-generics.cabal) | ||
* Given this [package.yaml](https://github.com/hspec/sensei/blob/main/package.yaml) running `hpack` will generate [sensei.cabal](https://github.com/hspec/sensei/blob/main/sensei.cabal) | ||
* Given this [package.yaml](https://github.com/haskell-compat/base-orphans/blob/main/package.yaml) running `hpack` will generate [base-orphans.cabal](https://github.com/haskell-compat/base-orphans/blob/main/base-orphans.cabal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this repo still uses master
as well.
While attempting to install
hpack
from the link referred to in the README:So, I figured I'd just do a quick string replace and submit a PR. It's just a quick edit and I haven't done any of the usual prerequisite legwork like checking to see if this duplicates work in an existing PR or anything, so feel free to completely disregard this PR and close it if it's not helpful ;)