NH-91517 only set response time HTTP attrs for HTTP server entry spans #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… basic otlp processor tests
cheempz
changed the title
cheempz
changed the title
xuan-cao-swi
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While checking over the lambda telemetry it was found that the trace response time metric, when gathered for a non-HTTP entry span (such as a "detached" AWS SDK client call), was still getting the HTTP metric attributes. This PR fixes the logic to be desired and in line with standard solarwinds processor behaviour.
Test (if applicable)
Enbled and updated the basic solarwinds OTLP processor tests now that OTel Metrics SDK is available. Haven't figured out how to verify actual processor on start/end behaviour re: generating some spans/metrics ;). Also saw
otel_lambda_config_test.rbcurrently skipped, maybe we address later or feel free to add to this PR.