Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-64310: remove the logic that set obfuscate for db from sw side #99

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

Description

As open-telemetry/opentelemetry-ruby-contrib#682 merged, no need this logic so remove them. Although, for RUBY 2.7, still need to manual set the obfuscate for instrumentation if needed.

e.g.

SolarWindsAPM::OTelConfig.initialize_with_config do |config|
  config["OpenTelemetry::Instrumentation::Dalli"] = {db_statement: :obfuscate}
  config["OpenTelemetry::Instrumentation::Mysql2"] = {db_statement: :obfuscate}
  config["OpenTelemetry::Instrumentation::PG"] = {db_statement: :obfuscate}
end

@xuan-cao-swi xuan-cao-swi requested a review from a team as a code owner January 2, 2024 19:13
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @xuan-cao-swi!

@xuan-cao-swi xuan-cao-swi merged commit 65c5a43 into main Jan 3, 2024
12 checks passed
@xuan-cao-swi xuan-cao-swi deleted the NH-64310 branch January 3, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants