-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about TypeScript requiring types for namespaced attributes #954
Open
titoBouzout
wants to merge
13
commits into
solidjs:main
Choose a base branch
from
titoBouzout:propswithtypes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
04d8141
fix unrelated syntax error
titoBouzout fb60aa0
include note about typings
titoBouzout c5b3f74
Merge branch 'main' into propswithtypes
kodiakhq[bot] 01b1d4a
Merge branch 'main' into propswithtypes
kodiakhq[bot] 56d754e
Merge branch 'main' into propswithtypes
kodiakhq[bot] 9c855d3
Merge branch 'main' into propswithtypes
kodiakhq[bot] 4780f13
Merge branch 'main' into propswithtypes
kodiakhq[bot] 3e43289
Merge branch 'main' into propswithtypes
kodiakhq[bot] 23b0f45
Merge branch 'main' into propswithtypes
kodiakhq[bot] 9470099
Merge branch 'main' into propswithtypes
kodiakhq[bot] cd06d58
Merge branch 'main' into propswithtypes
kodiakhq[bot] 42f4c90
Merge branch 'main' into propswithtypes
kodiakhq[bot] 51d6bcd
Merge branch 'main' into propswithtypes
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,5 @@ Forces the prop to be treated as a property instead of an attribute. | |
```tsx | ||
<div prop:scrollTop={props.scrollPos + "px"} /> | ||
``` | ||
|
||
Note: Type definitions are required when using TypeScript. See the [TypeScript](/configuration/typescript#forcing-properties-and-custom-attributes) page for examples. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can use the Callout component <Callout type="info" title="Strong-Typing Custom Properties">...</Callout> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the Callout component