Add rspec-retry dependency
#218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
bot
added
the
needs changelog label
Solidus core defines a spec helper module `spree/testing_support/flaky` which relies on `rspec-retry`. When using this from other gems, these gems have to know to require `rspec-retry`, even though they already have `solidus_dev_support`. I think it would be a good idea to just add it here instead of as a dev dependency on every extension that might have flaky specs.
mamhoff
force-pushed
the
add-rspec-retry-dependency
branch
from
b23941e
to
4e1ab4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidus core defines a spec helper module
spree/testing_support/flakywhich relies onrspec-retry. When using this from other gems, these gems have to know to requirerspec-retry, even though they already havesolidus_dev_support. I think it would be a good idea to just add it here instead of as a dev dependency on every extension that might have flaky specs.