Add Venmo as payment option #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanofWoods
force-pushed
the
add-venmo-as-payment-option
branch
2 times, most recently
from
7b3fe5c to
4b234dd
Compare
spec/models/solidus_paypal_commerce_platform/payment_method_spec.rb
Outdated
Show resolved
Hide resolved
spec/models/solidus_paypal_commerce_platform/payment_method_spec.rb
Outdated
Show resolved
Hide resolved
RyanofWoods
force-pushed
the
add-venmo-as-payment-option
branch
3 times, most recently
from
5d2595b to
1454bc5
Compare
RyanofWoods
changed the title
To reduce having unnecessary information on tests that do not explicitly involve Spree::Order checkout steps.
RyanofWoods
force-pushed
the
add-venmo-as-payment-option
branch
from
1454bc5 to
cc2e8cd
Compare
Resolves issue/ticket: - solidusio#136 If a transaction meets Venmo prerequisites [1], then Venmo button should appear already on checkout, cart and product page depending on payment method preferences. These changes is to give more control to the developer so that they can disable Venmo by setting the `enable_venmo` to false. https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#disable-funding As it Venmo may have already been showing for developers, the default was set to true. The enable-funding option is now also sent over to ensure that the Venmo button gets rendered if eligible: https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#enable-funding https://developer.paypal.com/docs/business/checkout/pay-with-venmo/integrate-pay-with-venmo/#always-request-venmo [1] https://developer.paypal.com/docs/business/checkout/pay-with-venmo/#eligibility
Resolves issue/ticket: - solidusio#137 Usually on checkout, PayPal will look at the buyer's location by their ip and determine which funding sources are available to them. For example, allow Venmo as an option for US buyers, but not for others. With this new preference, you can set a country to override the buyer location. Allowing you on non-production environments to see the different funding sources for different customers and its integration. This preference is still available on production but has no effect. It was kept on production to not have differences between the environments. Otherwise, errors could easily occur on production if for example, preferred_force_buyer_country method was incorrectly called. More information: https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#buyer-country
RyanofWoods
force-pushed
the
add-venmo-as-payment-option
branch
from
cc2e8cd to
2498c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues/tickets:
Setting the preference enable_venmo to true will now show a Venmo button
on checkout for customers whom it is available to.
For testing purposes, the string preference force_buyer_country was
added. You can use this to mock what country the buyer is from, allowing
you to see what funding sources are shown to customers in various
countries.
This preference does not affect checkout on production, environment.
Instead, PayPal will get this information from their ip geolocation.
More information:
https://developer.paypal.com/docs/business/javascript-sdk/javascript-sdk-configuration/#buyer-country