This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Feature/ae 1979 sakkopaatos valitusajan odotus ja umpeutuminen toimenpide #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solita-juhohaa
commented
Oct 24, 2023
|
|
||
| (def asha-toimenpide? | ||
| (partial some-type? #{:rfi-request | ||
| :rfi-order | ||
| :rfi-warning | ||
| :decision-order-hearing-letter | ||
| :decision-order-actual-decision | ||
| :decision-order-notice-first-mailing11 | ||
| :decision-order-notice-first-mailing |
There was a problem hiding this comment.
Ei liity tähän tickettiin, korjattiin typo.
solita-juhohaa
commented
Oct 24, 2023
Juholei
reviewed
Oct 24, 2023
.../test/clj/solita/etp/valvonta_kaytto/sakkopaatos_odotetaan_valitusajan_umpeutumista_test.clj
Show resolved
Hide resolved
etp-backend/src/main/clj/solita/etp/service/valvonta_kaytto/toimenpide.clj
Outdated
Show resolved
Hide resolved
solita-juhohaa
commented
Oct 30, 2023
| @@ -23,8 +23,12 @@ | |||
| 11 :decision-order-notice-bailiff | |||
| 12 :decision-order-waiting-for-deadline | |||
| 14 :penalty-decision-hearing-letter | |||
| 15 :change-when-implement-penalty-decision-actual-decision | |||
There was a problem hiding this comment.
Täytyi lisätä kaikille kannassa oleville toimenpiteille jokin placeholder tähän. Näitä on nyt siis idt 15, 18, 21. Laitoin eteen change-when-implement.
Id 19 on tämän ticketin toimenpide.
solita-juhohaa
commented
Oct 30, 2023
| @@ -52,26 +56,29 @@ | |||
| :decision-order-actual-decision | |||
| :decision-order-notice-first-mailing | |||
| :decision-order-notice-second-mailing | |||
| :decision-order-notice-bailiff})) | |||
| :decision-order-notice-bailiff | |||
| :decision-order-waiting-for-deadline})) | |||
There was a problem hiding this comment.
Ei liity tähän tickettiin, lisättiin puuttuva toimenpide.
…laceholders for missing
…fix problems Fixed typo in asha-toimenpide? and added missing toimenpide from sakkopaatos-toimenpide?
solita-juhohaa
force-pushed
the
feature/AE-1979-sakkopaatos-valitusajan-odotus-ja-umpeutuminen-toimenpide
branch
2 times, most recently
from
f33b8ea
to
3c24080
Compare
solita-juhohaa
commented
Oct 31, 2023
|
|
||
| (t/testing "Sakkoluettelon lähetys menossa" | ||
| (t/testing "has type-id 21 and type-key :change-when-implement-sakkoluettelo-delivery-ongoing" | ||
| (t/is (= (toimenpide/type-key 21) :change-when-implement-sakkoluettelo-delivery-ongoing))) |
There was a problem hiding this comment.
Lisätty testi, vaikka toteuttamatta vielä.
solita-juhohaa
commented
Oct 31, 2023
| (t/is (false? (toimenpide/asha-toimenpide? {:type-id 17}))))) | ||
|
|
||
| (t/testing "Sakkopäätös / tiedoksianto (Haastemies)" | ||
| (t/testing "has type-id 18 and type-key :change-when-implement-penalty-decision-notice-bailiff" | ||
| (t/is (= (toimenpide/type-key 18) :change-when-implement-penalty-decision-notice-bailiff))) |
There was a problem hiding this comment.
Lisätty testi, vaikka toteuttamatta vielä.
solita-juhohaa
commented
Oct 31, 2023
|
|
||
| (t/testing "Sakkopäätös / varsinainen päätös" | ||
| (t/testing "has type-id 15 and type-key :change-when-implement-penalty-decision-actual-decision" | ||
| (t/is (= (toimenpide/type-key 15) :change-when-implement-penalty-decision-actual-decision))) |
There was a problem hiding this comment.
Lisätty testi, vaikka toteuttamatta vielä.
Juholei
reviewed
Oct 31, 2023
etp-backend/src/test/clj/solita/etp/service/valvonta_kaytto/toimenpide_test.clj
Outdated
Show resolved
Hide resolved
etp-backend/src/test/clj/solita/etp/service/valvonta_kaytto/toimenpide_test.clj
Outdated
Show resolved
Hide resolved
solita-juhohaa
force-pushed
the
feature/AE-1979-sakkopaatos-valitusajan-odotus-ja-umpeutuminen-toimenpide
branch
from
3c24080
to
215cef6
Compare
Test that: - toimenpide in database has been assigned a type-key - there are no duplicate type-keys - predicates return what's expected for each toimenpide - type-key and type-id are what's expected for toimenpide
solita-juhohaa
force-pushed
the
feature/AE-1979-sakkopaatos-valitusajan-odotus-ja-umpeutuminen-toimenpide
branch
2 times, most recently
from
ecafb36
to
f1ed862
Compare
Juholei
approved these changes
Oct 31, 2023
solita-antti-mottonen
approved these changes
Oct 31, 2023
solita-juhohaa
deleted the
feature/AE-1979-sakkopaatos-valitusajan-odotus-ja-umpeutuminen-toimenpide
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.