This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Feature/ae 2029 #1044
Merged
Feature/ae 2029 #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juholei
force-pushed
the
feature/AE-2029
branch
6 times, most recently
from
65429ee
to
dff7f25
Compare
Juholei
requested review from
solita-juhohaa,
solita-antti-mottonen and
muep
… and sakkopäätös toimenpide - Henkilosapuoli and yritysosapuoli ids can be same so osapuoli-specific-data could get mixed up between the two if present in the same toimenpide - Added osapuoli-type to osapuoli-specific-data which is then checked together with the osapuoli-id if the osapuoli is the correct one
Juholei
force-pushed
the
feature/AE-2029
branch
from
dff7f25
to
793f9fb
Compare
solita-antti-mottonen
approved these changes
Nov 21, 2023
…apuoli-specific-data - Makes it clearer that both need to be checked for osapuoli to match
Juholei
force-pushed
the
feature/AE-2029
branch
from
166fbba
to
a847354
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.