This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Feature/ae 2036 aineisto s3 endpoint #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
5 times, most recently
from
a82482e
to
f272456
Compare
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
from
f272456
to
36576d9
Compare
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
from
36576d9
to
f53f2a6
Compare
Reading from a database is considered safe in STM transactions.
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
from
f53f2a6
to
23b7547
Compare
solita-juhohaa
requested review from
Juholei,
solita-antti-mottonen and
muep
Juholei
reviewed
Dec 11, 2023
muep
approved these changes
Dec 11, 2023
solita-juhohaa
commented
Dec 11, 2023
- Clarify the example in docstring - Remove unnecessary intermediate step when creating the uploaded-parts-vec - Actually return nil
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
from
e60ad84
to
19fda2f
Compare
- Improve comments - Don't rely on the order of the line in the csv - Add todistukset asap to test that signing them is the operation that makes them show in the csv - Change kayttotarkoitus to "RT" (rivitalo) to make something appear in the anonymized aineisto also
solita-juhohaa
force-pushed
the
feature/AE-2036-aineisto-s3-endpoint
branch
from
19fda2f
to
504993b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.