This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Upgrade Flyway #933
Merged
Upgrade Flyway #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solita-antti-mottonen
force-pushed
the
feature/AE-1909-upgrade-flyway
branch
5 times, most recently
from
57e03f7
to
a01ba3e
Compare
In 9.1.4 Flyway changed to use transactional locks, but it causes migrations to freeze. Reverted to old default. In 9.19.0 breaks things. Audit tables create a log of added kayttaja entries. The audit log try to use the function current_kayttaja_id(), which relies on "application name" being set. It's set in beforeMigration.sql, but in this version callbacks have a separate connection. Added ApplicationName to connection url to get around the problem. Implements: AE-1909
solita-antti-mottonen
force-pushed
the
feature/AE-1909-upgrade-flyway
branch
from
a01ba3e
to
7adf34f
Compare
Juholei
reviewed
Aug 23, 2023
| :password (env "DB_PASSWORD" "etp") | ||
| :url (env "DB_URL" "jdbc:postgresql://localhost:5432/postgres")}) | ||
| (let [url (env "DB_URL" "jdbc:postgresql://localhost:5432/postgres") | ||
| existing-query (-> url (str/split #"\?" 2) (get 1)) |
There was a problem hiding this comment.
Saisiko tästä ja seuraavasta rivistä jotenkin selvennettyä, että mitä tässä oikein tapahtuu? Ei ole omaan silmään mitenkään selkeää.
There was a problem hiding this comment.
Ehkä jopa omaksi funktiokseen eriyttäminen ja testien kirjoittaminen voisi olla hyvä?
solita-antti-mottonen
force-pushed
the
feature/AE-1909-upgrade-flyway
branch
from
1afe670
to
c5dfff2
Compare
Juholei
reviewed
Aug 24, 2023
| "Add ApplicationName to query parameters of the given url. | ||
|
|
||
| Example: | ||
| http://localhost:5763/db => http://localhost:5736?ApplicationName=0@database.etp |
There was a problem hiding this comment.
Portissa on typo kun se muuttuu tuossa syötteen ja esimerkkipaluuarvon välillä ja tuo db:kin tuossa häviää
Juholei
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9.1.4 Flyway changed to use transactional locks, but it causes
migrations to freeze. Reverted to old default.
In 9.19.0 something breaks. Audit tables create a log of added kayttaja
entries. The audit log try to use the function current_kayttaja_id(),
which relies on "application name" being set. It's set in
beforeMigration.sql, but for some reason it doesn't work anymore. The
script gets executed, so maybe there are multiple connections? Added
ApplicationName to connection url to get around the problem.