Add support for Windows to allow selecting between multiple tap0901 adapters on the same system
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adapters on the same system Co-authored-by: Neil Alexander <neilalexander@users.noreply.github.com>
songgao
reviewed
Mar 24, 2019
There was a problem hiding this comment.
Thanks for the PR @soffokl ! Code looks good to me. However, I don't have a Windows env set up to test this. I assume you've verified it works as expected? Also, could you please also add an example in readme that uses this new API?
Sorry for the delayed response.
|
@songgao I have added the description to readme. |
songgao
approved these changes
Mar 29, 2019
neilalexander
added a commit
to neilalexander/water
that referenced
this pull request
Jul 20, 2019
songgao
pushed a commit
that referenced
this pull request
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the original #37 from @neilalexander, but contains only support for Windows to allow selecting between multiple
tap0901adapters on the same system.It also contains styling fixes based on the original PR review.