sonic-gnmi: Master Arbitration #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm0930
reviewed
Apr 3, 2023
mm0930
reviewed
Apr 3, 2023
mm0930
reviewed
Apr 3, 2023
anand-kumar-subramanian
previously approved these changes
May 9, 2023
Adding doc for Master Arbitration HLD Signed-off-by: sallylyu@google.com
|
@sallylsy can you please add the code PRs if you have now? Thanks. |
|
@zhangyanzhao sure. Please find it here sonic-net/sonic-gnmi#96 |
|
community review recording https://zoom.us/rec/share/fhMIOkkDYx3INSShyKdXw9dXl8HqhBqQLxzG1mEUyvJrxdYbdGhofRS9Xs4MCh2g.aBeFosVoWBv3VBXi |
prvattem
reviewed
May 16, 2023
prvattem
reviewed
May 16, 2023
anand-kumar-subramanian
approved these changes
Jun 27, 2023
tomek-US
approved these changes
Aug 17, 2023
|
Hi @zhangyanzhao, the implementation of this HLD is merged. Can we get this HLD merged as well? We still need one more approval from community. |
venkatmahalingam
approved these changes
Aug 22, 2023
prvattem
approved these changes
Aug 22, 2023
rathnasabapathyv
approved these changes
Aug 22, 2023
adyeung
approved these changes
Aug 22, 2023
|
@sallylsy Can you please update the Quality Metric (Alpha/Beta/GA) for the feature either in this PR comments or in HLD itself based on https://github.com/sonic-net/SONiC/blob/master/doc/SONiC%20feature%20quality%20definition.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding doc for Master Arbitration HLD
Signed-off-by: sallylyu@google.com
Why I did it
Demonstrate the high level design of Master Arbitration feature.
How I did it
Provide the markdown document for the high level design.
How to verify it
We designed a set of unit test and system test cases to verify the Master Arbitration is working as expected.
Which release branch to backport (provide reason below if selected)
N/A. Master Arbitration high level design is not a fix. No backporting is needed.
Description for the changelog
No change in changelog
Link to config_db schema for YANG module changes
No change in config_db schema.
A picture of a cute animal (not mandatory but encouraged)